Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE][3.0.1 Release] Update country_code, assets config, typo #1166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JiahuiWho
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@philipliu
Copy link
Contributor

We don't typically create a new doc version for patch versions. Can we make the changes inline in 3.0.0 (this should 3.0)?

@stellar-jenkins
Copy link

@philipliu
Copy link
Contributor

The country_code field in the request sidebar still references the 3 letter country codes https://developers-pr1166.previews.kube001.services.stellar-ops.com/platforms/anchor-platform/api-reference/callbacks/get-rates.

Screenshot 2025-01-14 at 3 30 51 PM

enabled: true
- schema: iso4217
code: USD
deposit:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for 3.0? I see that it's missing min_amount and max_amount, and methods fields which I think are now required.

max_amount: 10000
receive:
min_amount: 0
max_amount: 10000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a methods field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants